[release/9.0] Dispose the certificate chain elements with the chain #62992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MackinnonBuck
added
the
Servicing-consider
artl93
added
Servicing-approved
halter73
approved these changes
Jul 31, 2025
This was referenced Sep 9, 2025
Closed
Bump Microsoft.AspNetCore.Authentication.JwtBearer from 9.0.5 to 9.0.9
imfaber/clean-architecture#13
Open
This was referenced Sep 17, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62531 to release/9.0
/cc @MackinnonBuck @jashook
Dispose the certificate chain elements with the chain
Fixes an issue in certificate authentication where certificates within a certificate chain were not getting directly disposed.
Description
Failing to dispose each certificate within an X509 chain can create significant GC pressure for applications that frequently perform TLS handshakes. While the previous disposal logic only disposed the
X509Chainitself, this PR updates the logic to first enumerate and dispose each certificate in the chain directly.Customer Impact
The original contribution was from a customer who determined that this issue has a severe negative performance impact on their large scale web application. See #62531 (comment).
Regression?
Risk
The change is straightforward and follows an established disposal pattern.
Verification
Packaging changes reviewed?